Review Request: 8173381: osName/osArch/osVersion is missing in ModuleDescriptor created by SystemModules

Mandy Chung mandy.chung at
Fri Jan 27 06:21:11 UTC 2017

> On Jan 26, 2017, at 12:33 AM, Alan Bateman <alan.bateman at> wrote:
> The set of modules has to include java.base so if it has all three properties then there is no need to call the builder methods for the other modules. That will save a few bytecodes at startup. It's not critical of course, just a small saving.

It’s a nice small optimization. I revised the patch to drop the ModuleTarget attribute, if java.base has all three properties.  I added a plugin option to retain the ModuleTarget attribute, primarily for testing purpose.

> Otherwise I think the change looks okay. At some point then the ModuleTarget class file attribute needs to be re-examined to see if the values it records are the right set. So it's possible it will change again. If there are more then I assume we can use one method to emit the instructions as they are builder method name / value pairs.

Updated webrev:


More information about the jigsaw-dev mailing list