RFR: CODETOOLS-7902928: Improve support for async-profiler 2.x [v2]

Aleksey Shipilev shade at openjdk.java.net
Mon May 10 10:08:06 UTC 2021

On Fri, 7 May 2021 06:06:18 GMT, Jason Zaugg <jzaugg at openjdk.org> wrote:

>> Allow multiple events to be captured simultaneously in this version,
>> provided that JFR is chosen as output format.
>> Delegate output file writing to the async-profiler. This is required
>> in 2.x for the JFR output but is supported in both versions. The file
>> path must be provided when starting the profiler with JFR output, so
>> we need to create the per-trial output directory in the first
>> `beforeIteration`.
>> Avoid the character '%' in the generated directory name as this
>> is interpreted by async-profiler as part %p or %t placeholder.
> Jason Zaugg has updated the pull request incrementally with one additional commit since the last revision:
>   Fixup: remove incorrect/unneeded 'reset' argument

Changes requested by shade (Committer).

jmh-core/src/main/java/org/openjdk/jmh/profile/AsyncProfiler.java line 101:

> 99:         OptionSpec<String> optEvent = parser.accepts("event",
> 100:                 "Event(s) to sample: cpu, alloc, lock, wall, itimer; com.foo.Bar.methodName; any event from `perf list` e.g. cache-misses")
> 101:                 .withRequiredArg().ofType(String.class).describedAs("event").defaultsTo(DEFAULT_EVENT);

Gotta say `.withValuesSeparatedBy(",")` here, see `optOutput` definition.


PR: https://git.openjdk.java.net/jmh/pull/37

More information about the jmh-dev mailing list