RFR: CODETOOLS-7902928: Improve support for async-profiler 2.x [v2]

Aleksey Shipilev shade at openjdk.java.net
Mon May 10 10:08:07 UTC 2021

On Mon, 10 May 2021 10:02:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Jason Zaugg has updated the pull request incrementally with one additional commit since the last revision:
>>   Fixup: remove incorrect/unneeded 'reset' argument
> jmh-core/src/main/java/org/openjdk/jmh/profile/AsyncProfiler.java line 101:
>> 99:         OptionSpec<String> optEvent = parser.accepts("event",
>> 100:                 "Event(s) to sample: cpu, alloc, lock, wall, itimer; com.foo.Bar.methodName; any event from `perf list` e.g. cache-misses")
>> 101:                 .withRequiredArg().ofType(String.class).describedAs("event").defaultsTo(DEFAULT_EVENT);
> Gotta say `.withValuesSeparatedBy(",")` here, see `optOutput` definition.

...can also inline `DEFAULT_EVENT`, while at it.


PR: https://git.openjdk.java.net/jmh/pull/37

More information about the jmh-dev mailing list