RFR: CODETOOLS-7902936: Stray output in forked VM breaks external version parsing [v3]

Aleksey Shipilev shade at openjdk.java.net
Wed May 26 07:02:23 UTC 2021

On Wed, 26 May 2021 04:07:40 GMT, Jason Zaugg <jzaugg at openjdk.org> wrote:

>> - Recover from stray output before the XML prelude
>>   - Report the output in the exception otherwise
>>   - Silence VM warnings in PrintPropertiesMain when JEP-158 (-Xlog:) is available (JRE 9+)
> Jason Zaugg has updated the pull request incrementally with one additional commit since the last revision:
>   Use a temporary file to read output of PrintPropertiesMain

This is good. Rename the test file, and we are good to go.

jmh-core-it/src/test/java/org/openjdk/jmh/it/jvmoption/JvmOption.java line 44:

> 42: @Fork(1)
> 43: @State(Scope.Thread)
> 44: public class JvmOption {

This should be `JvmOptionTest` to match the naming convention for the tests.


Marked as reviewed by shade (Committer).

PR: https://git.openjdk.java.net/jmh/pull/41

More information about the jmh-dev mailing list