RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars
christoph.langer at sap.com
Wed Nov 23 07:48:27 UTC 2016
to me this looks fine. Maybe a small cosmetical thing: Around lines 212 and 240 you could remove the additional empty lines to have one blank line between methods as in the rest of the file.
Note that I'm not a reviewer.
From: Frank Yuan [mailto:frank.yuan at oracle.com]
Sent: Mittwoch, 23. November 2016 05:41
To: core-libs-dev at openjdk.java.net; 'Daniel Fuchs' <daniel.fuchs at oracle.com>; Langer, Christoph <christoph.langer at sap.com>; 'Volker Simonis' <volker.simonis at gmail.com>; 'Joe Wang' <huizhe.wang at oracle.com>
Cc: code-tools-dev at openjdk.java.net; jtreg-use at openjdk.java.net
Subject: RFR JDK-8170192 [JAXP] [TESTBUG] test/javax/xml/jaxp/libs/jaxp/library/JAXPPolicyManager.java should grant permissions to jtreg, javatest, and testng jars
Would you like to review http://cr.openjdk.java.net/~fyuan/8170192/webrev.00/?
This patch is fully same as Daniel provided except a few lines of additional cleaning, thanks to Daniel for providing the patch!
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the jtreg-use