RFR (s) 8158906: JShell: crashes with extremely long result value

Jan Lahoda jan.lahoda at oracle.com
Fri Aug 19 08:33:35 UTC 2016

Overall, seems OK to me. Just a couple of minor comments to the test (up 
to you if you want to change the code or not):
-the test constructs a byte array and then constructs a String out of 
that - any reason why not not simply use a char array? Would seem 
cleaner to me.
-instead of:
assertTrue(shut[0] == false, "JShell died with long value");
why not say:
assertFalse(shut[0], "JShell died with long value");

(would more cleanly communicate the intent, I think).

No need for re-review.


On 19.8.2016 03:15, Robert Field wrote:
> Please review...
> Bug:
>      https://bugs.openjdk.java.net/browse/JDK-8158906
> Webrev:
>      http://cr.openjdk.java.net/~rfield/8158906v0.webrev/
> Thanks,
> Robert

More information about the kulla-dev mailing list