RFR: 8258754: Gracefully fallback to the OpenGL rendering pipeline if Metal rendering pipeline initialization fails [v8]

Kevin Rushforth kcr at openjdk.java.net
Tue Jan 19 15:00:01 UTC 2021

On Fri, 15 Jan 2021 20:59:14 GMT, Phil Race <prr at openjdk.org> wrote:

>> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
>>   handle invalid requests to use default pipeline
> src/java.desktop/macosx/classes/sun/java2d/macos/MacOSFlags.java line 115:
>> 113:                     } else if (metalState == PropertyState.ENABLED) {
>> 114:                         if (oglState == PropertyState.ENABLED) {
>> 115:                             oglEnabled = true;
> By adding the invalid state handling further up, this condition can never be true

Right. By the time we get here, the two flags cannot possibly be the same value, so you could simplify this by removing this check. That could be done as a follow-up.


PR: https://git.openjdk.java.net/lanai/pull/147

More information about the lanai-dev mailing list