Review request for 8011697: ScriptEngine "js" randomly means either "rhino" or "nashorn", but should instead select one
rieberandreas at gmail.com
Wed Sep 18 23:55:47 PDT 2013
On 19.09.2013 08:34, A. Sundararajan wrote:
> Few comments on this:
> 1) This is a JDK repo (where javax.script lives) change and so
> core-libs-dev review is needed
will do that (when i have 3).
> 2) Not sure if it affects any word on spec. - need to go through spec
> + javadoc comments closely
I checked the javadoc, there is nothing mentioned about the internal
implementation of the script engine factories. So this should be fine.
> 3) You need a test that demonstrates that order is preserved
I will try to setup a test with your sample script engine attached to
> Hope this helps,
> On Thursday 19 September 2013 11:43 AM, Andreas Rieber wrote:
>> the HashSet used for the script engine factories caused the random
>> Please review and sponsor required...
More information about the nashorn-dev