Please review JDK-8059211
marcus.lagergren at oracle.com
Fri Sep 26 12:10:02 UTC 2014
This is mostly a cosmetic fix that gets rid of a number of warnings that have been introduced recently. I started out by cleaning up the ArrayData subclasses. The optimistic builtins needed the array data.length field to be protected instead of private, and then no one needs to use the length function internally in any of the array data subclasses. Not that it matters performance wise, but it’s cleaner and the byte code is actually a bit shorter. There were various javadoc issues too in the same change, and some instance methods that could be turned into static ones. I want to check this in to reduce the warning level and for general cleanup. All tests and test262 pass.
Webrev at: http://cr.openjdk.java.net/~lagergren/8059211/webrev/
Bug at: https://bugs.openjdk.java.net/browse/JDK-8059211
More information about the nashorn-dev