RFR 8133872: Expression completion should work on contexts where an expression is accepted
sundararajan.athijegannathan at oracle.com
Wed Aug 19 03:01:21 UTC 2015
Yes, that is a good suggestion. I initially had it in Main.java and
refactored. Idea was to avoid exposing jdk.nashorn.internal.parser.* to
"jdk.scripting.nashorn.shell" module. But, you're right. Better to move
PartialParser interface to jdk.nashorn.tools package. I'll do that and
will send another webrev.
On 8/19/2015 7:30 AM, Hannes Wallnoefer wrote:
> Great work, Sundar!
> One question I have: why did you put getLastExpressionStart in
> Shell.java and make it protected there instead of implementing
> PartialParser right there?
> Am 2015-08-19 um 01:39 schrieb Sundararajan Athijegannathan:
>> I've updated this webrev slightly:
>> Changes from earlier webrev:
>> 1) Added PartialParser interface rather than passing Main object to
>> 2) Added key set to HistoryObject - so that "history." completion
>> will work as expected.
>> Everything else remains the same.
>> On 8/18/2015 10:40 PM, Michael Haupt wrote:
>>> Hi Sundar,
>>> lower-case thumbs up!
>>>> Am 18.08.2015 um 10:04 schrieb Sundararajan Athijegannathan
>>>> <sundararajan.athijegannathan at oracle.com>:
>>>> Please review http://cr.openjdk.java.net/~sundar/8133872/ for
More information about the nashorn-dev