RFR 8133948: Add 'edit' function to allow external editing of scripts

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Thu Aug 20 13:11:08 UTC 2015


Please review the updated webrev (in place).


I tested this on Windows with external editors being notepad.exe, 
gvim.exe and internal editor.Thanks to Hannes for testing it on Ubuntu.

As I mentioned earlier EditPad and ExternalEditor are cloned from Kulla 
project and modified to suit nashorn shell requirements. We can revisit 
and refactor code to jdk.internal.le module later.


On 8/20/2015 4:45 PM, Sundararajan Athijegannathan wrote:
> Please ignore this webrev. I'll update it in-place and send a review 
> request later..
> Thanks
> -Sundar
> On 8/19/2015 10:02 PM, Sundararajan Athijegannathan wrote:
>> Forgot to CC Jan ...
>> -Sundar
>> On 8/19/2015 10:01 PM, Sundararajan Athijegannathan wrote:
>>> Please review http://cr.openjdk.java.net/~sundar/8133948/ for 
>>> https://bugs.openjdk.java.net/browse/JDK-8133948
>>> Note: ExternalEditor and EditPad classes are from kulla/jshell code 
>>> - modified to suite nashorn jjs. Perhaps eventually code could be 
>>> refactored and reused from jdk.interanal.le.
>>> Thanks,
>>> -Sundar

More information about the nashorn-dev mailing list