RFR 8145486: jjs should support documentation key shortcut in interactive mode

Sundararajan Athijegannathan sundararajan.athijegannathan at oracle.com
Wed Dec 16 10:33:45 UTC 2015

Thanks for the reviews.

Updated webrev: http://cr.openjdk.java.net/~sundar/8145486/webrev.01/

* Fixed documentation for setIndexedPropertiesToExternalArrayData
* Fixed inner/nested class case ($ - > ".")
* Added doc for NativeJavaPackage objects
* Added missing "final" in Console.bind method.

Incremental changes are only in Main.java and Console.java

Please review..


On 12/16/2015 2:48 PM, Hannes Wallnoefer wrote:
> Very nice, and works like a charm on Linux.
> One nitpick: documentation for 
> NativeObject.setIndexedPropertiesToExternalArrayData should start with 
> "sets" rather than "set" to be consistent with the rest.
> Hannes
> Am 2015-12-16 um 05:38 schrieb Sundararajan Athijegannathan:
>> Please review http://cr.openjdk.java.net/~sundar/8145486/ for 
>> https://bugs.openjdk.java.net/browse/JDK-8145486
>> Note that this enhancement only adds jjs changes to show 
>> documentation when available and infrastructure to attach 
>> documentation string for JS built-in functions, constructors.
>> Actual documentation strings are added only for NativeObject. Adding 
>> documentation string for all other built-in functions, constructors 
>> will be done in future.
>> Thanks,
>> -Sundar

More information about the nashorn-dev mailing list