RFR: JDK-8085822 JEP 223: New Version-String Scheme (initial integration)
erik.joelsson at oracle.com
Mon Jun 8 09:05:02 UTC 2015
Looks pretty good. Found some typos:
124, 132: --with--version-pre-base has a dash too many? I see this
pattern consistently used though, am I missing something?
On 2015-06-05 16:07, Magnus Ihse Bursie wrote:
> This review request covers the main part of the work for JEP-223, the
> new version string format . Basically, we'll call this release Java
> "9", instead of Java "1.9.0".
> This patch is a folding of all work that has been done so far in the
> branch JEP-223-branch in jdk9/sandbox. As you can see, it mostly
> covers build changes, with some code changes in hotspot, jdk, nashorn
> and langtools that either are corresponding changes in the product
> code due to the compiler define flags changing from the build, or
> follow-up changes to handle the new format.
> The JEP-223 work is not finished by this patch. In fact, there are
> known issues remaining even after this patch, typically by code that
> reads the "java.version" property and tries to parse it. However, this
> patch is not directly destined for jdk9/dev, but will go into the
> special verona/stage forest. As for all patches destined for
> verona/stage it will be code reviewed as if going to jdk9/dev. Once in
> verona/stage it will bide its time, and it will be complemented with
> follow-up patches to address remaining issues. When all such issues
> are resolved and JEP-223 is fully implemented, all changes will be
> pushed at once (without further code reviews) into jdk9/dev.
> This patch has been contributed by Magnus Ihse Bursie, Kumar
> Srinivasan and Alejandro Murillo.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8085822
>  http://openjdk.java.net/jeps/223
More information about the nashorn-dev