Review request for JDK-8098808: Convert Scope from interface to class

Hannes Wallnoefer hannes.wallnoefer at
Wed Jun 17 10:47:12 UTC 2015

Yes, I noticed that as well. I decided to follow the ScriptObject (super 
class) parameter order in Scope. I could have changed order in 
FunctionScope as well, but that class is only used in generated code, so 
it didn't seem worth it.

Thanks for the review.


Am 2015-06-17 um 11:06 schrieb Attila Szegedi:
> One minor nitpick I have is that the order of arguments in the constructor for Scope is the opposite of what it was in FunctionScope; you might want to fix that before the push, but in any case it’s +1.
>> On Jun 17, 2015, at 9:42 AM, Attila Szegedi <attila.szegedi at> wrote:
>> +1
>>> On Jun 16, 2015, at 4:05 PM, Hannes Wallnoefer <hannes.wallnoefer at> wrote:
>>> Please review JDK-8098808: Convert Scope from interface to class:
>>> Thanks,
>>> Hannes

More information about the nashorn-dev mailing list