RFR 8141285: NameCode should pass tests from BytecodeNameTest.java

Michael Haupt michael.haupt at oracle.com
Tue Nov 3 15:40:45 UTC 2015

Hi Sundar,

lower-case thumbs up!



> Am 03.11.2015 um 15:31 schrieb Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com>:
> Please review http://cr.openjdk.java.net/~sundar/8141285/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8141285
> NameCodec has similar functionality (with a minor bug in '\' handling) as in sun.invoke.util.BytecodeName.java (which seems to be old code, but unused in jdk repo!). Using code in BytecodeName.java in NameCodec.java now - only minimal subset needed for decode, encode. Also, adding tests for NameCodec.java derived from (older) mlvm test BytecodeNameTest.java
> Thanks,
> -Sundar


Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment

More information about the nashorn-dev mailing list