Review request for JDK-8143304: Random failures when script size exceeds token limits
marcus at lagergren.net
Thu Nov 19 16:17:05 UTC 2015
Perhaps set a larger heap limit in the test if someone runs with a pathologic JVM config, but no biggie.
> On 19 Nov 2015, at 14:44, Hannes Wallnoefer <hannes.wallnoefer at oracle.com> wrote:
> Please review JDK-8143304: Random failures when script size exceeds token limits:
> This assigns 28 bits to both the position and the length in the parser token, and makes sure source files don't exceed this limit in the parser.
> Previously we used 32 bits for the position and only 24 for the length. The thinking behind that probably was that a token would never be as long as the whole script but that turns out to be wrong (like for the main script function, or a very long object or array literal).
More information about the nashorn-dev