Regarding JDK-8142968

Attila Szegedi szegedia at
Wed Mar 23 14:41:57 UTC 2016

Hi folks,

I just now got to review the "8142968: Module System implementation” commit, rather its Nashorn-specific parts. Overall it looks good, I have one small objection: formatting in JavaAdapterBytecodeGenerator seems off, I think some tab characters snuck in.

I also don’t fully understand why switched from sourceFor(String, URL) to sourceFor(String, InputStream) - is that related to modules at all, or is just an optimization in that Class.getResourceAsStream is more efficient than going through URL.openConnection().getInputStream()? (In any case, I’m fine with it.)


More information about the nashorn-dev mailing list