RFR: 8156619: Unimplemented ES6 features should result in clear Error being thrown
sundararajan.athijegannathan at oracle.com
Mon Nov 7 12:15:42 UTC 2016
While it is okay on generators, reporting super keyword usage with
function declaration looks bit odd.. That said, it is not very serious.
On 11/7/2016 5:22 PM, Hannes Wallnöfer wrote:
> Thanks Sundar.
> For the super keyword, we store its usage in the function while super itself is a normal identifier. For generators, the function actually is the entity although you could argue we should point to the * token that makes it a generator. I’d rather not have to change these, I hope you’re fine with that.
>> Am 07.11.2016 um 11:30 schrieb Sundararajan Athijegannathan <sundararajan.athijegannathan at oracle.com>:
>> generator and super keyword "not yet implemented" errors (carets in
>> error message) point to the beginning of the function declaration
>> (rather than to the exact place of issue). Other than that, +1
>> On 11/7/2016 3:31 PM, Hannes Wallnöfer wrote:
>>> Please review:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8156619
>>> Webrev: http://cr.openjdk.java.net/~hannesw/8156619/webrev.00/
>>> Note that this also contains a small fix in Parser which was an oversight in my previous backport of ES6 changes from Graaljs. It made some destructuring cases impossible to detect but does not affect the syntax we currently support, which is why it wasn’t noticed before.
More information about the nashorn-dev