RFR: 8184241(Fix nashorn/samples/filebrowser.js)

Srinivas Dama srinivas.dama at oracle.com
Wed Jul 19 17:35:37 UTC 2017

Hi Hannes,
Thank you for the comments.

Here is the new patch using our own base class instead of TreeItem in test case.


-----Original Message-----
From: Hannes Wallnöfer 
Sent: Wednesday, July 19, 2017 2:51 PM
To: Srinivas Dama
Cc: Nashorn-Dev
Subject: Re: RFR: 8184241(Fix nashorn/samples/filebrowser.js)

Hi Srini,

The fix looks good, but what for is the arguments handling in the test? 

Also, I would prefer to use our own base class (constructor must invoke overridable method, what if TreeItem is refactored in the future?)


> Am 19.07.2017 um 10:45 schrieb Srinivas Dama <srinivas.dama at oracle.com>:
> Hi,
> Please review http://cr.openjdk.java.net/~sdama/8184241/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8184241.
> Regards,
> Srinivas

More information about the nashorn-dev mailing list