<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi,<div class=""><br class=""></div><div class="">Sorry for the delay.</div><div class=""><br class=""></div><div class="">Alan: I’ve changed `testInitialSendBufferSize` in the test `test/java/net/DatagramSocket/SetGetSendBufferSize.java` to now check the limit when the socket is IPv6 only. I’ve also updated the tests to be end-to-end (rather than use the loopback) as requested. </div><div class=""><br class=""></div><div class="">Vyom: I’ve updated the fix to use int constants now in place of values. </div><div class=""><br class=""></div><div class="">webrev: <a href="http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.01/" class="">http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.01/</a></div><div class=""><br class=""></div><div class="">Kind regards,</div><div class="">Patrick<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 10 May 2020, at 14:32, Vyom Tiwari <<a href="mailto:vyommani@gmail.com" class="">vyommani@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div class="">Looks good to me, minor comment can you please use some int constant in place of <span class="gmail-new">(65527, 65507) ?.</span></div><div class=""><span class="gmail-new">Vyom<br class=""></span></div><div class=""><span class="gmail-new"></span></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, May 8, 2020 at 7:19 PM Patrick Concannon <<a href="mailto:patrick.concannon@oracle.com" class="">patrick.concannon@oracle.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br class="">
<br class="">
Could someone please review my fix for JDK-8242885 <br class="">
'PlainDatagramSocketImpl doesn’t allow for the sending of IPv6 datagrams <br class="">
on macOS with sizes between 65508-65527 bytes'?<br class="">
<br class="">
This fix changes the current max size for IPv6 datagrams on macOS from <br class="">
it's current size of 65507, which is the IPv4 limit, to65527, the actual <br class="">
limit for IPv6 on macOS. This will get around the issue of not being <br class="">
able to send datagrams with sizes between65508-65527 bytes.<br class="">
<br class="">
bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8242885" rel="noreferrer" target="_blank" class="">https://bugs.openjdk.java.net/browse/JDK-8242885</a><br class="">
webrev: <a href="http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.00/" rel="noreferrer" target="_blank" class="">http://cr.openjdk.java.net/~pconcannon/8242885/webrevs/webrev.00/</a><br class="">
<br class="">
<br class="">
Kind regards,<br class="">
<br class="">
Patrick<br class="">
<br class="">
</blockquote></div><br clear="all" class=""><br class="">-- <br class=""><div dir="ltr" class="gmail_signature">Thanks,<br class="">Vyom</div>
</div></blockquote></div><br class=""></div></body></html>