RFR[12] of JDK-8207316, java/nio/channels/spi/SelectorProvider/inheritedChannel/InheritedChannelTest.java failed

Volker Simonis volker.simonis at gmail.com
Thu Jul 19 07:17:26 UTC 2018

Hi Hamlin,

in general your change looks good, but isn't the default timeout
factor "1" ? In that case your patch now effectively reduces the
timeout for these tests if they are being run with the default
configuration. Shouldn't your change use the current timeout values
instead and make them subject to the timeout factor adjustment?

Thank you and best regards,

On Thu, Jul 19, 2018 at 9:00 AM, Hamlin Li <huaming.li at oracle.com> wrote:
> Would you please review the following patch?
> https://bugs.openjdk.java.net/browse/JDK-8207316
> http://cr.openjdk.java.net/~mli/8207316/webrev.00/
> Thank you
> -Hamlin

More information about the nio-dev mailing list