RFR[11] of JDK-8207244, java/nio/channels/Selector/SelectWithConsumer.java testInterruptDuringSelect() fails intermittently

Hamlin Li huaming.li at oracle.com
Thu Jul 19 08:20:03 UTC 2018

On 2018/7/19 3:52 PM, Alan Bateman wrote:
> On 19/07/2018 08:47, Hamlin Li wrote:
>> Hi Alan,
>> Thank you for review, I have updated in place: 
>> http://cr.openjdk.java.net/~mli/8207244/webrev.00/
> Utils.adjustTimeout doesn't make sense here as the duration of select 
> is not a function of the timeout factor specified to jtreg. 
I think it's better to have Utils.adjustTimeout, remember this issue is 
reported because of "select took 5204 ms", it could take longer than 
that. so I think we'd better to scale select timeout according to jtreg 
timeout factor.
> I think the solution to this issue is a one-line fix - either drop the 
> assert (as it's not useful here) or change it to just check that 
> select didn't complete immediately.
Sure, I think so too, will drop the assert.

patch is updated in place: 

Thank you

> -Alan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180719/f70e50a6/attachment.html>

More information about the nio-dev mailing list