8207804: (bf) Consider removing blank lines from generated Buffer sources

Brian Burkhalter brian.burkhalter at oracle.com
Thu Jul 19 21:09:17 UTC 2018

On Jul 19, 2018, at 1:56 PM, mark.reinhold at oracle.com wrote:

> 2018/7/19 13:17:09 -0700, brian.burkhalter at oracle.com:
>> https://bugs.openjdk.java.net/browse/JDK-8207804
>> Diff included below. Please refer also to the comments in the issue.
> As Alan observed in a comment on the issue, the blank lines are there
> for a reason: So that it’s easier to debug problems in the editable
> source code, which is what matters, as opposed to the generated source.
> Is it worth reducing maintainability in order to make these generated
> files prettier for those who might read them in IDEs?  I agree that the
> number of people inconvenienced will be small, but they’re the ones
> doing the actual work.  I’d prefer to leave the blank lines as-is.

FWIW I attached to the issue a simple Perl script I already had which does a credible job of making the generated files prettier to look at, at least for purposes of code inspection.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180719/7782e375/attachment-0001.html>

More information about the nio-dev mailing list