RFR[11] of JDK-8207833, java/nio/channels/Selector/SelectWithConsumer.java testCancel() fails intermittently

Hamlin Li huaming.li at oracle.com
Fri Jul 20 01:07:04 UTC 2018

On 2018/7/19 7:33 PM, Alan Bateman wrote:
> On 19/07/2018 10:07, Hamlin Li wrote:
>> Would you please review the following patch?
>> bug: https://bugs.openjdk.java.net/browse/JDK-8207833
>> webrev: http://cr.openjdk.java.net/~mli/8207833/webrev.00/
> Can you swap key1 and key2 so that key1 is created first? It may 
> confuse further maintainers to create key2 first.
> Also can be group the creation of key1 with select, and then key2 with 
> selectNow. The changes mean there's a blank line after creating key1 
> and it's no longer obvious that it needs the selectNow to register the 
> key.
Sure, it's updated in place.

Thank you
> -Alan

More information about the nio-dev mailing list