5071718: (bf) Add ByteBuffer.slice(int offset, int length)

Brian Burkhalter brian.burkhalter at oracle.com
Tue Feb 26 15:55:32 UTC 2019

> On Feb 26, 2019, at 12:43 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 26/02/2019 01:48, Brian Burkhalter wrote:
>> Hi Brent,
>> That does read better.
> It's consistent with the existing slice method so I think it's good too.

Webrev [1] and CSR [2] updated accordingly.

> Otherwise looks good to me, kudos to Roger for spotting the error with the 0 length case, that would have been embarrassing to get wrong.

Indeed: good catch, Roger!



[1] http://cr.openjdk.java.net/~bpb/5071718/webrev.02/
[2] https://bugs.openjdk.java.net/browse/JDK-8219608
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190226/66580251/attachment.html>

More information about the nio-dev mailing list