5071718: (bf) Add ByteBuffer.slice(int offset, int length)

Brian Burkhalter brian.burkhalter at oracle.com
Wed Feb 27 01:06:52 UTC 2019

> On Feb 26, 2019, at 9:41 AM, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:
>> On Feb 26, 2019, at 9:32 AM, Alan Bateman <Alan.Bateman at oracle.com <mailto:Alan.Bateman at oracle.com>> wrote:
>> One small suggestion for the class description is to merge the two paragraphs on the slice methods into one to avoid the duplicate wording, it might be as simpler as "The slice() and slice(int,int) methods create a subsequence of a buffer; They leave the limit and position unchanged".
> Voila:
>  *   <li><p> The {@link #slice} and {@link #slice(int,int) slice(index,length)}
>  *   methods create a subsequence of a buffer: They leave the limit and the
>  *   position unchanged. </p></li>

I created one more webrev [1] which includes the above change and adds some test coverage in java/nio/Buffer/StringCharBufferSliceTest.java which had been lacking.



[1] http://cr.openjdk.java.net/~bpb/5071718/webrev.03/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190226/1917647f/attachment.html>

More information about the nio-dev mailing list