<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">+1<div class=""><br class=""></div><div class="">Paul.<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jan 13, 2020, at 4:44 PM, Brian Burkhalter <<a href="mailto:brian.burkhalter@oracle.com" class="">brian.burkhalter@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=us-ascii" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div class=""><blockquote type="cite" class=""><div class="">On Jan 13, 2020, at 8:49 AM, Brian Burkhalter <<a href="mailto:brian.burkhalter@oracle.com" class="">brian.burkhalter@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="" style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div class=""><blockquote type="cite" class="" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none;"><div class="">On Jan 11, 2020, at 12:10 AM, Alan Bateman <<a href="mailto:Alan.Bateman@oracle.com" class="">Alan.Bateman@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span class="" style="caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: none; float: none; display: inline !important;">The spec/impl looks good. The tests for alignmentOffset are in open/test/java/nio/ByteBuffer so better to keep them in one place if possible.</span></div></blockquote></div><br class=""><div class="">Are you suggested simply to move the test as-is or incorporate the testing into, e.g., BasicByte?</div></div></div></blockquote></div><br class=""><div class="">Here [1] is a version which puts the new test code into existing files.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class=""><br class=""></div><div class="">Brian</div><div class=""><br class=""></div><div class="">[1] <a href="http://cr.openjdk.java.net/~bpb/8230665/webrev.01/" class="">http://cr.openjdk.java.net/~bpb/8230665/webrev.01/</a></div></div></div></blockquote></div><br class=""></div></body></html>