<div class="socmaildefaultfont" dir="ltr" style="font-family:Arial, Helvetica, sans-serif;font-size:10pt" ><div dir="ltr" >Looks good to me.</div>
<div dir="ltr" >Vyom</div>
<div dir="ltr" > </div>
<blockquote data-history-content-modified="1" dir="ltr" style="border-left:solid #aaaaaa 2px; margin-left:5px; padding-left:5px; direction:ltr; margin-right:0px" >----- Original message -----<br>From: "linzang(臧ç³)" <linzang@tencent.com><br>To: Vyom Tewari26 <vtewar26@in.ibm.com><br>Cc: "linzang(臧ç³)" <linzang@tencent.com>, nio-dev <nio-dev@openjdk.java.net><br>Subject: [EXTERNAL] Re: RE: RFR: JDK-8239139 testmake fail with warning about strncpy using gcc version 8(Internet mail)<br>Date: Tue, Feb 18, 2020 11:35 AM<br>
<div><font size="2" face="Default Monospace,Courier New,Courier,monospace" >Dear Vyom, <br> Your change looks good to me. <br> And I have updated it to <a href="http://cr.openjdk.java.net/~lzang/8239139/webrev02/" target="_blank">http://cr.openjdk.java.net/~lzang/8239139/webrev02/</a> .<br><br>Thanks, <br>Lin<br><br>>Hi Lin,<br>><br>>thanks for fixing this issue, i think your changes will have similar warnings with -Wformat-truncation flag. What do you think about below patch ?.<br>><br>>Thanks,<br>>Vyom<br>><br>>--- a/test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c Mon Feb 17 18:52:50 2020 -0800<br>>+++ b/test/jdk/java/nio/channels/spi/SelectorProvider/inheritedChannel/libInheritedChannel.c Tue Feb 18 10:09:50 2020 +0530<br>>@@ -232,11 +232,12 @@<br>> {<br>> struct sockaddr_un addr;<br>> const char *nameUtf = (*env)->GetStringUTFChars(env, name, NULL);<br>>- int ret = -1;<br>>+ int ret = -1, length=sizeof(addr.sun_path);<br>> unlink(nameUtf);<br>> memset(&addr, 0, sizeof(addr));<br>> addr.sun_family = AF_UNIX;<br>>- strncpy(addr.sun_path, nameUtf, strlen(nameUtf));<br>>+ strncpy(addr.sun_path, nameUtf, length);<br>>+ addr.sun_path[length - 1] = '\0';<br>> ret = bind(sock, (const struct sockaddr*)&addr, sizeof(addr));<br>> if (ret == -1) {<br>> ThrowException(env, "java/io/IOException", "socket bind error");<br>><br>>----- Original message -----<br>>From: "linzang(臧ç³)" <linzang@tencent.com><br>>Sent by: "nio-dev" <nio-dev-bounces@openjdk.java.net><br>>To: Alan Bateman <Alan.Bateman@oracle.com>, nio-dev <nio-dev@openjdk.java.net><br>>Cc:<br>>Subject: [EXTERNAL] Re: Re: RFR: JDK-8239139 testmake fail with warning about strncpy using gcc version 8(Internet mail)<br>>Date: Tue, Feb 18, 2020 5:57 AM<br>> <br>>Thanks Alan.<br>><br>>Hi all,<br>> May I get more review about this tiny patch? Thanks!<br>><br>>--------------<br>>Lin<br>>>On 17/02/2020 10:37, linzang(臧ç³) wrote:<br>>>> From updates in <a href="https://bugs.openjdk.java.net/browse/JDK-8239139" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8239139</a> ,<br>>>> This is related to a test case of recent nio patch.<br>>>> so move this thread to nio-dev.<br>>>><br>>>Yes, this test was expanded recently to run the launcher with stdin<br>>>connected to a Unix domain socket. The len parameter should have been<br>>>sizeof(addr.sun_path) but changing this to snprintf looks okay too.<br>>><br>>>-Alan.<br>>><br>><br>></font></div></blockquote>
<div dir="ltr" > </div></div><BR>