Image class and paths relative to classpath
martin.sladecek at oracle.com
Tue Apr 24 06:40:03 PDT 2012
There's one open question: how to handle relative classpath URI (like
When used in Image constructor, I think the most intuitive approach is
to take it as relative to the class that is calling the constructor.
However, it might be more tricky with fxml & css. Neither of them needs
to be on classpath, so relative classpath url wouldn't make sense.
So we might either not support relative classpath URIs at all for fxml &
css or just trow an exception when used in external files.
Also guys working on fxml & css should comment whether it's even
possible to resolve classpath URIs relative to the fxml or css file,
which should mean 'in the same package' in this case.
On 04/24/2012 09:12 AM, Daniel Zwolenski wrote:
> True. On the other hand classpath uri does allow you to use an externally configured URL (eg loaded from a properties file) and this can change without code changing.
> Eg in my app I might have the default image URL load off the classpath but then someone wants to reference an image on the web and they can just change the url setting. No need for a code change.
> Fairly common scenario for me anyway. I'd love to see classpath uri supported across the board. FXML, image, CSS, etc.
> There's some interesting stuff on this here:
> On 24/04/2012, at 2:20 PM, Martin Sladecek<martin.sladecek at oracle.com> wrote:
>> I have no strong preference, classpath URI scheme is one of the options we may use. The only downside of this approach I see is that people will have to read through the Image's constructor javadoc to find out that there's this option.
>> On 04/23/2012 05:37 PM, Daniel Zwolenski wrote:
>>> An alternative to the separate method is to define a 'classpath' protocol as part of the URL:
>>> Image image = new Image("classpath:/foo/bar.png");
>>> This is common in Spring and seems quite nice to me. It has the advantage of working with constructors and is fully backwards compatible.
>>> I could live with a new method if that was the preference though.
>>> On 23/04/2012, at 10:58 PM, Martin Sladecek<martin.sladecek at oracle.com> wrote:
>>>> JIRA: http://javafx-jira.kenai.com/browse/RT-18291
>>>> this JIRA request is about adding support for "URL" in Image constructor that is interpreted as a classpath-relative path when a leading slash is present.
>>>> However, this is currently interpreted as absolute file URL.
>>>> In order not to break current behaviour I propose to introduce new set of static factory methods.
>>>> Image.fromClassPath(String path, double requestedWidth, double requestedHeight, boolean preserveRatio, boolean smooth, boolean backgroundLoading);
>>>> + overloaded method similar to Image constructors.
>>>> The idea is to interpret paths with leading slash as absolute to the classpath root (basically the same as Thread.currentThread().getContextClassLoader().getResource(path) ), while relative paths might be interpreted as relative to the caller class. So Image.fromClassPath("duke.jpg") called from myapplication.Application will look for the file in myapplication package.
>>>> What do you think?
More information about the openjfx-dev