API REVIEW REQUEST: Public API for Backgrounds and Borders on Region

Richard Bair richard.bair at oracle.com
Mon Aug 27 07:23:27 PDT 2012

> * In BorderRadii, I'm not overly familiar with the terminology of some
>   of the methods in this class. For example,
>   getTopLeftVerticalRadius(). I wonder if the JavaDoc can be more
>   useful than "The length of the vertical radii of the top-left
>   corner."? Of course, I could just become more well-versed in the CSS
>   specifications :-)

Will do!

> * In BorderRadii, I understand that the radii can be interpreted as
>   either a value or a percentage, but I'm not fond of the method name
>   you use to expose this, e.g. isTopLeftVerticalRadiusAsPercentage().
>   It is the 'As' that bothers me - I would have rather had an 'A', but
>   I can see why you chose to use 'As' - so that we don't end up with
>   isTopLeftVerticalRadiusAPercentage() (which is actually less
>   readable, even if it is better English). Personally, I would still
>   use 'A' rather than 'As', but I'm not going to pursue it any further
>   as it is a gut feel choice (and you've used 'As' throughout the
>   Region API).

Ah right. Frankly I hate the names no matter what 'cause they're huge! But you are right, it reads better with the "is" if it says "A" instead of "As".


More information about the openjfx-dev mailing list