[REVIEW REQUEST] RT-33442: isSelected in TableViewSelectionModel is called too many times

Jonathan Giles jonathan.giles at oracle.com
Fri Oct 18 12:24:48 PDT 2013

On 19/10/2013 2:13 a.m., Stephen F Northover wrote:
> If it is a noop, will it not break people when the system calls it and
> it does nothing?

Only the abstract TableSelectionModel is a no-op, the implementations
(one each for TableView and TreeTableView) will both override and
provide the implementation that I already have in the patch for
TableView. I would rather have the implementation in the base class but
this is not feasible due to requirements in looking up column indices.
> Further, what about discontinuous selections (ie. one item, then an
> unselected item, then a million selected items in a block).  You can
> do this on native Windows using Shift+Ctrl+Select but I see that this
> is not supported in the FX table.

I haven't included discontinuous selection in this round of performance
research, but in general the changes in the RT-33442 changeset will have
the same drastic improvement there as well. However, as you note, there
is not a full implementation of discontinuous selection implemented in
TableView yet, so the point is a little moot at this stage.

-- Jonathan

More information about the openjfx-dev mailing list