[8u40] Review Request: (RT-38138) -fx-spacing used wrong in .menubar in modena.css

David Grieve david.grieve at oracle.com
Wed Aug 6 12:59:04 UTC 2014

Kevin, Steve,

Jonathan has reviewed https://javafx-jira.kenai.com/browse/RT-38138 and 
given his +1. I'm in need of a +1 from one of you before I push.

-------- Original Message --------
Subject: 	[8u40] Review Request: (RT-38138) -fx-spacing used wrong in 
.menubar in modena.css
Date: 	Tue, 05 Aug 2014 16:12:06 -0400
From: 	David Grieve <david.grieve at oracle.com>
To: 	Jonathan Giles <jonathan.giles at oracle.com>
CC: 	openjfx-dev at openjdk.java.net List <openjfx-dev at openjdk.java.net>


Please review https://javafx-jira.kenai.com/browse/RT-38138. There are
two patches attached. The first just addresses the problem in modena.css
(and caspian.css). The second addresses the problem in MenuBarSkin and
leaves modena.css (and caspian.css) unmodified. It is the second patch
(RT-38138_01.patch) that I recommend we move forward with as it keeps
styling MenuBar and ToolBar very much the same.

After your review, I'll seek a +1 from Kevin or Steve.

More information about the openjfx-dev mailing list