[8u60,9] review request: 8088823: Advanced Media Player tab does not respond to "Time" slider on Windows

Kirill Kirichenko kirill.kirichenko at oracle.com
Mon Jun 15 14:21:16 UTC 2015

Hi Alexander, Kevin.

Could you please review the following fix?
jbs: https://bugs.openjdk.java.net/browse/JDK-8088823
wevrev: http://cr.openjdk.java.net/~stayer/8088823/webrev.00/

Please review and comment in JBS.

This patch partly fixes regression after 
https://bugs.openjdk.java.net/browse/JDK-8092944 and partly fixes 
missing parts. In JDK-8092944 DeliverSample fails in 
CBaseOutputPin::GetDeliveryBuffer with E_NOINTERFACE because 
m_pAllocator is NULL. So this patch does not ignore all errors that are 
not E_FAIL.
Patch in gstqueue.c allows to generate GST_ELEMENT_ERROR even if there 
is no eos in the queue. Without this part _loop task is silently stops 
and application is not generating any errors.
Patch in flvdemux.c just cleans redundancy. It's just not necessary.

I'd say that some SQE effort is necessary for testing this patch better.


More information about the openjfx-dev mailing list