[9] Review request for 8134996: GSTREAMER_LITE conditional compilation should be used for all changes in GStreamer

Kirill Kirichenko kirill.kirichenko at oracle.com
Mon Sep 7 10:43:38 UTC 2015

1) Some files have empty diffs: 
and some more.

2) what's the purpose of surrounding in 
in GSTREAMER_LITE ? Can we just compile with G_ENABLE_DEBUG if needed ?

as far as I know we compile with G_DISABLE_DEPRECATED so this code won't 
be included hence why to change ?

4) I'm not sure we need these 
files I included them long ago without any reason.

5) Where do we need functions from 
Maybe if it's our code we could rewrite it to make sure we don't use 
deprecated ghtread at all ?

Overall looks fine. So approved.


On 05.09.2015 6:20, Alexander Matveev wrote:
> Hi Kirill and Kevin,
> Please review the fix:
> https://bugs.openjdk.java.net/browse/JDK-8134996
> http://cr.openjdk.java.net/~almatvee/8134996/webrev.00/
> - Added missing GSTREAMER_LITE.
> - Fixed some white spaces.
> - Fixed line ending for some files.
> - Several files were not merged correctly with latest GStreamer.
> - Deleted several unused files.
> Thanks,
> Alexander

More information about the openjfx-dev mailing list