[9] RFR-XL: 8091485: Ensemble8: Review each sample

Morris Meyer morris.meyer at oracle.com
Tue Feb 9 22:01:47 UTC 2016


Enclosed is my very large webrev for Ensemble8 that has visual 
appearance changes for each and every sample file.

Every sample was gone through and checked for appearance, related docs 
and links.

Every sample code file was scrubbed for bad variable names, long-lines, 
readability, clarity, and comment format.

Every sample now has a link to the JavaFX documentation relevant to that 
sample, an ordered list of API links for the sample and a populated list 
of related samples.

Each link in each sample was tested to verify correct linkage and accuracy.

All changes were to the samples source code and not Samples.java file.

Every import statement in each sample was tested to see if the source 
code actually used it.  Lots of imports were culled.

After these changes Ensemble8 would be much more ready for the Apple App 

I apologize in advance for the length of this webrev and will buy lunch 
for anyone that actually goes through it next time I'm in Santa Clara.

Use the follow to test out the changes:

ant -Dplatforms.JDK_1.8.home=`/usr/libexec/java_home` 
ensemble-generate-samples-class run


         --morris meyer

WEBREV - http://cr.openjdk.java.net/~morris/JDK-8091485.03/
BUG - https://bugs.openjdk.java.net/browse/JDK-8091485

More information about the openjfx-dev mailing list