[Review request] 8088853: Applying dashed border to separator makes whole application hang

Jim Graham james.graham at oracle.com
Wed Feb 17 20:05:04 UTC 2016

Looks great.  Approved...


On 2/17/2016 1:11 AM, Andrey Rusakov wrote:
> Updated that:
> <http://cr.openjdk.java.net/%7Earusakov/8088853/webrev.01>http://cr.openjdk.java.net/~arusakov/8088853/webrev.01
> 17.02.2016 01:22, Jim Graham пишет:
>> [I believe you sent this to the wrong mailing list - the "-request"
>> list is for changing your membership to the mailing list, not for
>> sending mail to the list itself.  I fixed it here in my reply...]
>> That looks fine.  I'll note that the "dashCumulative" variable does
>> not need to be computed if you don't recompute the gapLength at line
>> 1580, so that line (#1578) can be moved inside the if statement.
>> Other than that, it looks good...
>>             ...jim
>> On 2/15/2016 2:50 AM, Andrey Rusakov wrote:
>>> Hello, everyone! Could you look at my fix for JDK-8147944?
>>> http://cr.openjdk.java.net/~arusakov/8088853/webrev.00

More information about the openjfx-dev mailing list