[PATCH] 8160325: Provide a public API to obtain the FXCanvas for an embedded scene.
alexander at nyssen.org
Thu Jul 28 15:43:47 UTC 2016
I have added my comments below:
> Am 28.07.2016 um 17:22 schrieb Kevin Rushforth <kevin.rushforth at oracle.com>:
> I got the attachment, since Alexander also CCed me directly. I will attach it shortly.
> I do have two comments on this:
> 1) We are past Feature Freeze, so all Enhancements need formal JDK 9 R-team approval . In this case, the justification can be internal API that is no longer accessible in JDK 9 due to Jigsaw (I would be very reluctant to consider any other Enhancement request this late in the process), but I will need to look at it and then take it through the approval process, provided that I feel it is in scope.
I was not aware about this, but I would of course appreciate if it could be included (due to Jigsaw). Thanks for considering it at least.
> 2) Some of the changes you list seem unrelated to this enhancement and are better done as separate issues (e.g., the rework of the SWTCursorsTest). Also, I am unconvinced of the need to force GTK 2; in fact it seems at odds with the work we have done with JEP 283 .
Well, the test case refactoring is somehow related, as I introduced the common SWT rule while introducing the second SWT test. However, I could provide it as a separate contribution if that was wished (and a JIRA issue was provided), but the rest of this contribution of course requires it as a prerequisite. If this enhancement could not be included in JDK 9, I would have to provide it as a separate contribution, as I would have to re-introduce FXCanvasTest in other succeeding bugfix contributions (JDK-8143596, JDK-8143596).
The GTK2 flag I introduced just affects SWT. As the swt library that is bundled is rather old (3.7.2) that seemed to be safer (we have observed quite a few problems when running SWT on GTK3). We can of course remove it if tests are not affected by it.
> — Kevin
>  http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-June/004485.html
>  http://openjdk.java.net/projects/jdk9/fc-extension-process
>  https://bugs.openjdk.java.net/browse/JDK-8145568
> Phil Race wrote:
>> The mailing list rejects attachments so we got nothing.
>> On 7/28/2016 8:06 AM, Alexander Nyssen wrote:
>>> Hi Kevin, all,
>>> attached please find a patch that fixes JDK-8160325. The patch comprises the following changes:
>>> - Provided static FXCanvas#getFXCanvas(Scene) method to obtain the FXCanvas instance embedding the given Scene instance.
>>> - Added EmbeddedWindow.getHost() so the HostInterface can be retrieved.
>>> - Added FXCanvasTest with a test method to test correct behavior of FXCanvas#getFXCanvas(Scene).
>>> - Introduced SwtTest JUnit MethodRule to have more concise tests and ensure it is also used by SWTCursorsTest.
>>> - Ensured SWT tests are executed using GTK2 on Linux.
>>> I reworked the existing SWTCursorsTest while introducing FXCanvasTest to be more concise.
More information about the openjfx-dev