[10] Review Request: JDK-8179399 - Call trim() when loaded jre.list (Vivek Rao)

Vivek Rao vivek.x.rao at oracle.com
Wed Jun 21 19:01:33 UTC 2017


Chris, Victor, 
Please review the following change for fixing the “stripComments” method for redistributableModules. 

Bug URL: https://bugs.openjdk.java.net/browse/JDK-8179399 <https://bugs.openjdk.java.net/browse/JDK-8179399>
Webrev: http://cr.openjdk.java.net/~vrao/JDK-8179399/ <http://cr.openjdk.java.net/~vrao/JDK-8179399/>

1. When each line of jre.list is loaded in RedistributableModules.java trim() should be called
2. NoSuchElementException not caught for ModuleReference 
3. Unused imports

Using trim() inside stripComments to remove unnecessary space and cleaning the if else condition.
Added NoSuchElementException
Removed all unused imports

Thanks and regards, 
Vivek Rao

More information about the openjfx-dev mailing list