[9] Review request: 8170701: Update FXML documentation for setAccessible

Mandy Chung mandy.chung at oracle.com
Sat Mar 4 22:50:06 UTC 2017

> On Mar 4, 2017, at 5:14 PM, Kevin Rushforth <kevin.rushforth at oracle.com> wrote:
> http://cr.openjdk.java.net/~kcr/8170701/webrev.01/

  40  * object {@link Module#isOpen opens} the containing package to the

Nit: s/@link/@linkplain

  41  * {@code javafx.fxml} module, either in its {@link ModuleDescriptor}
  42  * (module-info.class) or by calling {@link Module#addOpens}.

Do you intend to take out “(module-info.class)”?  

  43  * An object is also reflectively accessible if it is declared as public,

Does “it” mean its constructor?

  44  * is in a public class, and the module containing that class
  45  * {@link Module#isExported(String,Module) exports}

Nit: s/@link/@linkplain

  46  * the containing package to the {@code javafx.fxml} module.

This is word-smithing and formatting nit.  No need to send a new webrev.


More information about the openjfx-dev mailing list