[10] Review request : JDK-8187379 : VirtualContainerBase: createVirtualFlow must be protected

Kevin Rushforth kevin.rushforth at oracle.com
Tue Nov 21 12:47:10 UTC 2017

Hi Ajit,

Thank you for looking into this. It seems a good addition to the API (as 
suggested by Jeanette W).

We will need some unit tests for the new API, if possible. Also, the 
javadoc needs a bit of work. The description of createVirtualFlow looks 
good, but it is missing an '@return' and an '@since' tag. The 
getVirtualFlow() method could use a second sentence to indicate that 
subclasses can call this method to get the VirtualFlow instance. It is 
also missing an '@return' and '@since' tag.

Please target this to 10, and file a CSR after updating the javadoc 


-- Kevin

Ajit Ghaisas wrote:
> Hi Kevin, 
>       Request you to review following fix :
>       Issue :  https://bugs.openjdk.java.net/browse/JDK-8187379
>       Fix for JDK 10 :   http://cr.openjdk.java.net/~aghaisas/fx/8187379/webrev.0/
> Regards,
> Ajit

More information about the openjfx-dev mailing list