[11] RFR JDK-8202199 : Provide public, unsupported API for FX Swing interop

Kevin Rushforth kevin.rushforth at oracle.com
Tue May 8 23:33:54 UTC 2018

The module definition for jdk.unsupported.desktop and the changes to 
java.desktop look fine.

In reviewing the jdk.swing.interop API, I have the following suggestions 
/ observations:

1. DispatcherWrapper, DragSourceContextWrapper, 
DropTargetContextWrapper, and LightweightContentWrapper can all be 
abstract, along with most of the methods (rather than having an empty 
body return value that is never used).

2. The addNotify method in LightweightFrameWrapper is unused. Should be 
used somewhere? If not, then it can be removed.

The implementation of the new wrapper classes looks OK to me with one 
observation that might or might not matter:

3. The behavior of getDefaultScaleX/Y (which is now in 
SwingInteropUtils) has changed in the case where the Graphics is not an 
instance of SunGraphics2D. The former behavior was to leave the instance 
variables X and Y unchanged. The new behavior will set them back to 1.0. 
Maybe this can't happen in practice, but it is something to consider.

-- Kevin

On 5/8/2018 3:31 AM, Alan Bateman wrote:
> On 08/05/2018 06:51, Prasanta Sadhukhan wrote:
>> Modified webrev to rename to InteropProviderImpl
>> http://cr.openjdk.java.net/~psadhukhan/fxswing.10/
> This looks okay to me.
> -Alan

More information about the openjfx-dev mailing list