[12] RFR: JDK-8210092: Remove old javafx.swing implementation

Kevin Rushforth kevin.rushforth at oracle.com
Tue Sep 25 12:33:27 UTC 2018

Yes, that seems like a good bit of additional cleanup. I'll do that.

-- Kevin

On 9/25/2018 1:41 AM, Prasanta Sadhukhan wrote:
> Hi Kevin,
> Removal looks ok but one thing, do we still need to keep the 
> enhanced-for loop in InterOpFactory.java#getInstance now that we have 
> only 1 factory? I guess we can probably remove the whole reflection 
> thing also and instantiate InteropFactoryN directly, no?
> Regards
> Prasanta
> On 22-Sep-18 5:23 AM, Kevin Rushforth wrote:
>> Please review the following on GitHub:
>> https://bugs.openjdk.java.net/browse/JDK-8210092
>> https://github.com/javafxports/openjdk-jfx/pull/207
>> https://github.com/javafxports/openjdk-jfx/pull/207/files
>> This will remove the old JDK-10-based implementation of FX / Swing 
>> interop and cleanup the build to remove the legacy qualified exports 
>> and the logic that optionally excludes the new implementation. It 
>> also changes the dependency that javafx.swing has on 
>> jdk.unsupported.desktop from "requires static" (optional) to 
>> "requires", which will fix an existing bug with jlinked images that 
>> include javafx.swing.
>> -- Kevin

More information about the openjfx-dev mailing list