RFR: 8130738: TextFlow's tab width is static
swpalmer at gmail.com
Thu Nov 7 20:27:08 UTC 2019
Yes, I suppose this should behave like anything else that uses an
IntegerProperty as far as bindings are concerned. I'll wait for further
review before reverting that last change. If tabSize=0 worked reasonably it
would be much simpler. I'm not sure if I will have the time to hunt down
why things go wrong in that case (everything after a tab appears at x
I've created the CSR, hopefully I did it correctly.
On Thu, Nov 7, 2019 at 9:57 AM Kevin Rushforth <kcr at openjdk.org> wrote:
> On Wed, 6 Nov 2019 19:11:48 GMT, Scott Palmer <swpalmer at openjdk.org>
> > Added tabSize property to Text and TextFlow and -fx-tab-size CSS
> attribute to both. TextFlow's tab size overrides that of contained Text
> > ----------------
> > Commits:
> > - 68d221c7: 8130738: TextFlow's tab width is static
> > Changes: https://git.openjdk.java.net/jfx/pull/32/files
> > Webrev: https://webrevs.openjdk.java.net/jfx/32/webrev.00
> > Issue: https://bugs.openjdk.java.net/browse/JDK-8130738
> > Stats: 324 lines in 8 files changed: 260 ins; 0 del; 64 mod
> > Patch: https://git.openjdk.java.net/jfx/pull/32.diff
> > Fetch: git fetch https://git.openjdk.java.net/jfx pull/32/head:pull/32
> > I should clamp so it reads back as 1 - Fixed.
> This has implications for binding, etc., so I suspect this is not what we
> want. I'll look into this more when I review it.
> NOTE: This will need a CSR in addition to two reviewers. You can file the
> CSR any time, but I suggest leaving it in Draft state until Phil and I have
> had a first pass look at the API.
> PR: https://git.openjdk.java.net/jfx/pull/32
More information about the openjfx-dev