[Approved] RFR: 8232687: No static JNI loader for libprism-sw

Kevin Rushforth kcr at openjdk.org
Mon Oct 21 20:06:40 UTC 2019

On Mon, 21 Oct 2019 10:03:24 GMT, Johan Vos <jvos at openjdk.org> wrote:

> This PR adds a JNI_OnLoad_prism_sw call to the static lib libprism_sw.a.
> This approach is similar to the addition of e.g. JNI_OnLoad_prism_es2 that has been done as part of https://bugs.openjdk.java.net/browse/JDK-8223760 
> Unless -PSTATIC_BUILD is provided when building, this patch has no impact.
> ----------------
> Commits:
>  - 6f31ee6b: Add JNI_OnLoad_prism_sw call to make prism-sw work with static libs
> Changes: https://git.openjdk.java.net/jfx/pull/19/files
>  Webrev: https://webrevs.openjdk.java.net/jfx/19/webrev.00
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8232687
>   Stats: 16 lines in 1 file changed: 16 ins; 0 del; 0 mod
>   Patch: https://git.openjdk.java.net/jfx/pull/19.diff
>   Fetch: git fetch https://git.openjdk.java.net/jfx pull/19/head:pull/19

Looks good. One minor formatting comment.

Approved. This one is simple enough I don't think it needs a second review.


Approved by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/19

More information about the openjfx-dev mailing list