[Rev 03] RFR: 8236840: Memory leak when switching ButtonSkin

Ambarish Rapte arapte at openjdk.java.net
Thu Apr 2 12:58:11 UTC 2020

> ButtonSkin adds a `ChangeListener` to `Control.sceneProperty()` which results in leaking the `ButtonSkin` itself when
> the `Button`'s skin is changed to a new `ButtonSkin`.  Using a `WeakChangeListener` instead of `ChangeListener` solves
> the issue.
> Please take a look.

Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:

  Fixed review comment: cleanup the accelerator


  - all: https://git.openjdk.java.net/jfx/pull/147/files
  - new: https://git.openjdk.java.net/jfx/pull/147/files/e81f175a..bf974f6a

 - full: https://webrevs.openjdk.java.net/jfx/147/webrev.03
 - incr: https://webrevs.openjdk.java.net/jfx/147/webrev.02-03

  Stats: 54 lines in 2 files changed: 46 ins; 0 del; 8 mod
  Patch: https://git.openjdk.java.net/jfx/pull/147.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/147/head:pull/147

PR: https://git.openjdk.java.net/jfx/pull/147

More information about the openjfx-dev mailing list