[Rev 03] RFR: 8236840: Memory leak when switching ButtonSkin

Jeanette Winzenburg fastegal at openjdk.java.net
Thu Apr 2 13:42:45 UTC 2020

On Thu, 2 Apr 2020 12:58:11 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> ButtonSkin adds a `ChangeListener` to `Control.sceneProperty()` which results in leaking the `ButtonSkin` itself when
>> the `Button`'s skin is changed to a new `ButtonSkin`.  Using a `WeakChangeListener` instead of `ChangeListener` solves
>> the issue.
>> Please take a look.
> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>   Fixed review comment: cleanup the accelerator

looks good :)


Marked as reviewed by fastegal (Author).

PR: https://git.openjdk.java.net/jfx/pull/147

More information about the openjfx-dev mailing list