RFR: 8236971: [macos] Gestures handled incorrectly due to missing events
kcr at openjdk.java.net
Fri Apr 3 14:34:32 UTC 2020
On Fri, 3 Apr 2020 14:14:36 GMT, Michael Paus <mpaus at openjdk.org> wrote:
>> These are all separate issues that could be explored with follow-on bugs. I'm not sure what the right behavior is for
>> these or whether there is enough information from the OS to do anything about them (e.g., I suspect there is no way to
>> get the touch count for these trackpad-generated gestures on macOS, nor do I really think it would be useful). You
>> might file a follow-on issue for 1 and 3.
>> Would you be able to review this? If not I'll ask @johanvos or @pankaj-bansal to be the second reviewer.
> I think 1. is more a point for discussion and I am also not sure what is right or wrong but 3. is IMHO a bug,
> especially because the documentation is so explicit about this behaviour. I'll file a new issue for that.
> What would I have to do to formally review this? I haven't done that before.
I agree about 1 being a point of discussion. Please do file a bug for 3.
As for formally reviewing it, you would press the `Files changed` tab near the top of the PR, add any inline comments
you might have, and then press the `Review changes` pull down. You would add any overall review comments that you have,
then select one of `Comment` (to add comments or questions before approving), `Approve` (this means you have reviewed
it and are OK with the changes; you will be listed as a reviewer), or `Request changes` (to indicate a bug or other
serious problem), and then press `Submit Review`.
More information about the openjfx-dev