[Rev 03] RFR: 8238954: Improve performance of tiled snapshot rendering
kcr at openjdk.java.net
Wed Apr 15 21:46:18 UTC 2020
On Wed, 15 Apr 2020 17:20:55 GMT, Frederic Thevenet <github.com+7450507+fthevenet at openjdk.org> wrote:
>> At first glance, the NPE in [JDK-8189082](https://bugs.openjdk.java.net/browse/JDK-8189082) occurs in the Prism layer,
>> which is one level _below_ Quantum where the tiling is currently implemented, so I'm not sure tit is reachable from
>> there; if we want the code to be shared, it looks like it would need to be moved even further down (maybe in the
>> `ResourceFactory`?) Also, while reusing code is generally the way to go, in such lower layers, very closely
>> intertwined with the actual rendering, I'm afraid that insisting on having a "one-size-fits-all" implementation might
>> get in the way of necessary case-by-case optimizations, so I'd like to have someone with a deeper knowledge of the
>> code base to weight in before starting work in that direction. Maybe @kevinrushforth could advise?
> Hi everyone,
> This PR hasn't seen much activity in a while, so I though I would give it a gentle kick to hopefully get it moving
> again ;) As explained above, I feel a little stalled at the moment, as we need to decide whether or not it is a good
> idea to try and address all or part of JDK-8189082 within the scope of this PR, and I don't feel like I can settle
> that on my own. Thanks.
Sorry for the delay. This is on my review queue, which has been growing of late. I'll take a look at it soon.
To answer one of your questions:
> we need to decide whether or not it is a good idea to try and address all or part of JDK-8189082 within the scope of
> this PR
I think your idea of addressing the other similar cases (Canvas and SubScene in particular) in a follow-up PR seems
fine. If, at that time, you find you can refactor this to share some of the implementation, that would be good.
More information about the openjfx-dev