RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

Jesper Skov github.com+2720909+jskov at openjdk.java.net
Sun Apr 19 09:36:12 UTC 2020

On Sat, 18 Apr 2020 15:50:55 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Make the two ways of associating a ToggleButton with a ToggleGroup interact correctly.
>> This fixes https://bugs.openjdk.java.net/browse/JDK-8198402
> modules/javafx.controls/src/main/java/javafx/scene/control/ToggleButton.java line 196:
>> 195:     private ObjectProperty<ToggleGroup> toggleGroup;
>> 196:     @Override
>> 197:     public final void setToggleGroup(ToggleGroup value) {
> This is unrelated to the fix. The changes in this file should be reverted.

OK.  They are gone.

Would this (keeping the changes very specific to the bug?) be worth mentioning in CONTRIBUTING.md?
That is, like the note about imports: do not fix warnings that are not directly related to the issue?


PR: https://git.openjdk.java.net/jfx/pull/167

More information about the openjfx-dev mailing list