[Rev 01] RFR: 8198402: ToggleButton.setToggleGroup causes memory leak when button is removed via ToggleGroup.getToggles()

Jesper Skov github.com+2720909+jskov at openjdk.java.net
Sun Apr 19 09:58:42 UTC 2020

On Sat, 18 Apr 2020 16:04:34 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jesper Skov has updated the pull request incrementally with three additional commits since the last revision:
>>  - Fail instead of print message
>>  - addedToggles list is final
>>  - Leave unrelated file alone
> The fix looks correct to me. Have you run all tests to ensure no regressions?
> I left a couple inline comments.

@kevinrushforth I tested by:
bash ./gradlew clean all test -x :web:test
I assumed that would do it.
But I see use of ToggleButton in javafx.web, so that was clearly a faulty assumption.

I will try to get webkit working.


PR: https://git.openjdk.java.net/jfx/pull/167

More information about the openjfx-dev mailing list